feat(subform): backend handling of datatype calls from preview #13971
+571
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/app-preview
github-actions
bot
added
the
quality/testing
Jondyr
added
the
skip-releasenotes
mlqn
approved these changes
Nov 5, 2024
| { | ||
| [Authorize] | ||
| [AutoValidateAntiforgeryToken] | ||
| [Route("{org:regex(^(?!designer))}/{app:regex(^(?!datamodels$)[[a-z]][[a-z0-9-]]{{1,28}}[[a-z0-9]]$)}")] |
There was a problem hiding this comment.
I'd suggest moving /instances to the base route here, as you did with /data in the DataController?
Suggested change
| [Route("{org:regex(^(?!designer))}/{app:regex(^(?!datamodels$)[[a-z]][[a-z0-9-]]{{1,28}}[[a-z0-9]]$)}")] | |
| [Route("{org:regex(^(?!designer))}/{app:regex(^(?!datamodels$)[[a-z]][[a-z0-9-]]{{1,28}}[[a-z0-9]]$)}/instances")] |
| { | ||
| public static class PreviewConstants | ||
| { | ||
| public static readonly Guid MockInstanceGUID = new("f1e23d45-6789-1bcd-8c34-56789abcdef0"); |
There was a problem hiding this comment.
This constant does not seem to be in use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves preview of subform table components.
Changes made to backend:
DataControllerandInstanceControllerin a new directorypreview/Moved over existing endpoints from
PreviewControllerto these filesIsolates preview backend calls from studio, and tries to stay true to altinn-app-api format for easier source lookup
preview/directoryDataPatchRequestandDataPatchResponsesubform-component-preview-pr.mp4
Related Issue(s)
Verification
Documentation